-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCC-4428 - Pass item source in kebab case to hold forms #424
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question
src/utils/appUtils.ts
Outdated
export const convertCamelToShishKabobCase = (str: string) => | ||
str | ||
// Change capital letters into "-{lowercase letter}" | ||
.replace(/([A-Z])/g, (c, p1, i) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the p1
and i
for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i
is the index needed to skip the first character, and p1 is a placeholder arg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updated these var names for clarity
Ticket:
This PR does the following:
How has this been tested?
Accessibility concerns or updates
Checklist: